From 00cffe2881c09ad8958f79ec5595cc92ff076d61 Mon Sep 17 00:00:00 2001 From: KerollesFathy Date: Tue, 7 Apr 2026 14:50:57 +0000 Subject: [PATCH 1/2] fix(filter): remove empty values from value --- frappe/public/js/frappe/ui/filters/filter.js | 1 + 1 file changed, 1 insertion(+) diff --git a/frappe/public/js/frappe/ui/filters/filter.js b/frappe/public/js/frappe/ui/filters/filter.js index 95ac66013f..c67d7036a0 100644 --- a/frappe/public/js/frappe/ui/filters/filter.js +++ b/frappe/public/js/frappe/ui/filters/filter.js @@ -493,6 +493,7 @@ frappe.ui.filter_utils = { } catch { val = val.split(",").map((v) => strip(v)); } + val = val.filter((v) => v != null && v !== ""); // remove empty values } } else if (frappe.boot.additional_filters_config[condition]) { val = field.value || val; From 14edcce3b48475dcec40eb0d04efb4e7ad91080b Mon Sep 17 00:00:00 2001 From: KerollesFathy Date: Tue, 7 Apr 2026 15:34:47 +0000 Subject: [PATCH 2/2] refactor: remove empty values after splitting --- frappe/public/js/frappe/ui/filters/filter.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/ui/filters/filter.js b/frappe/public/js/frappe/ui/filters/filter.js index c67d7036a0..d07f11d111 100644 --- a/frappe/public/js/frappe/ui/filters/filter.js +++ b/frappe/public/js/frappe/ui/filters/filter.js @@ -491,9 +491,11 @@ frappe.ui.filter_utils = { const parsed = JSON.parse(val); val = Array.isArray(parsed) ? parsed : [String(parsed)]; } catch { - val = val.split(",").map((v) => strip(v)); + val = val + .split(",") + .map((v) => strip(v)) + .filter((v) => v != null && v !== ""); } - val = val.filter((v) => v != null && v !== ""); // remove empty values } } else if (frappe.boot.additional_filters_config[condition]) { val = field.value || val;