From 52bf52790d3cf6b2f28dc317135987d5cc2cab6d Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Thu, 12 Mar 2020 14:25:25 +0530 Subject: [PATCH] refactor: desk page update handling --- frappe/desk/doctype/desk_page/desk_page.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/frappe/desk/doctype/desk_page/desk_page.py b/frappe/desk/doctype/desk_page/desk_page.py index cbe6c53881..dd9cc0706a 100644 --- a/frappe/desk/doctype/desk_page/desk_page.py +++ b/frappe/desk/doctype/desk_page/desk_page.py @@ -10,13 +10,19 @@ from frappe.model.document import Document class DeskPage(Document): def validate(self): - if (self.is_standard and not frappe.conf.developer_mode and \ - not (frappe.flags.in_install or frappe.flags.in_patch or frappe.flags.in_test or frappe.flags.in_fixtures)): + if (self.is_standard and not frappe.conf.developer_mode and not disable_saving_as_standard()): frappe.throw(_("You need to be in developer mode to edit this document")) def on_update(self): - if frappe.flags.in_install or frappe.flags.in_patch or frappe.flags.in_test or frappe.flags.in_fixtures: + if disable_saving_as_standard(): return if frappe.conf.developer_mode and self.is_standard: export_to_files(record_list=[['Desk Page', self.name]], record_module=self.module) + +def disable_saving_as_standard(): + return frappe.flags.in_install or \ + frappe.flags.in_patch or \ + frappe.flags.in_test or \ + frappe.flags.in_fixtures or \ + frappe.flags.in_migrate \ No newline at end of file