vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

chore: revert transition rule for 0 to 2

Browse source 
doing explicit transition check for discard because,
* there's only one transition check that is required
* draft(0) > cancelled(2) and submitted(1) > cancelled(2) are valid
  checkes for save so it doesn't make sense editing
  check_docstatus_transition
This commit is contained in:
Rutwik Hiwalkar 2024-04-17 20:51:04 +05:30
parent 82d61b32e4
commit 5335d6c19c
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
frappe/model/document.py
View file

@ -848,7 +848,9 @@ class Document(BaseDocument):
self._action = "submit"
self.check_permission("submit")
elif self.docstatus.is_cancelled():
self.check_permission("write")
raise frappe.DocstatusTransitionError(
_("Cannot change docstatus from 0 (Draft) to 2 (Cancelled)")
)
else:
raise frappe.ValidationError(_("Invalid docstatus"), self.docstatus)
@ -1058,10 +1060,14 @@ class Document(BaseDocument):
@frappe.whitelist()
def discard(self):
"""Discard the draft document. Sets `docstatus` = 2, then saves."""
"""Discard the draft document. Sets `docstatus` = 2 with db_set."""
self.check_if_locked()
self.set_user_and_timestamp()
self.check_if_latest()
if not self.docstatus == DocStatus.draft():
raise frappe.ValidationError(_("Only draft documents can be discarded"), self.docstatus)
self.check_permission("write")
self.run_method("before_discard")
self.db_set("docstatus", DocStatus.cancelled())