From 408d9d1d20ab69fe27ed928f6899141f6040c213 Mon Sep 17 00:00:00 2001
From: Anand Doshi <anand@erpnext.com>
Date: Fri, 23 Aug 2013 11:28:15 +0530
Subject: [PATCH 1/2] [fix] [minor] use for loop instead of $.map in query
 report to map data, to avert Uncaught RangeError: Maximum call stack size
 exceeded error

---
 public/js/wn/views/query_report.js | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/public/js/wn/views/query_report.js b/public/js/wn/views/query_report.js
index 318dd356d5..e1664969fb 100644
--- a/public/js/wn/views/query_report.js
+++ b/public/js/wn/views/query_report.js
@@ -227,15 +227,17 @@ wn.views.QueryReport = Class.extend({
 	},
 	make_data: function(result, columns) {
 		var me = this;
-		this.data = $.map(result, function(row, row_idx) {
+		this.data = [];
+		for(var row_idx=0, l=result.length; row_idx < l; row_idx++) {
+			var row = result[row_idx];
 			var newrow = {};
-			for(var i=1, j=me.columns.length; i<j; i++) {
-				newrow[me.columns[i].field] = row[i-1];
+			for(var i=1, j=this.columns.length; i<j; i++) {
+				newrow[this.columns[i].field] = row[i-1];
 			};
 			newrow._id = row_idx + 1;
 			newrow.id = newrow.name ? newrow.name : ("_" + newrow._id);
-			return newrow;
-		});
+			this.data.push(newrow);
+		}
 	},
 	make_dataview: function() {
 		// initialize the model

From a16db647dfa56a0c9b0f8e3fc3cd94b475ef54a6 Mon Sep 17 00:00:00 2001
From: Anand Doshi <anand@erpnext.com>
Date: Fri, 23 Aug 2013 12:56:32 +0530
Subject: [PATCH 2/2] [fix] [minor] trigger grid_fieldname_remove function on
 removing grid row

---
 public/js/wn/form/grid.js | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/public/js/wn/form/grid.js b/public/js/wn/form/grid.js
index 590c10d9c0..fd23d6011c 100644
--- a/public/js/wn/form/grid.js
+++ b/public/js/wn/form/grid.js
@@ -201,11 +201,14 @@ wn.ui.form.GridRow = Class.extend({
 		}
 	},
 	remove: function() {
-		var me = this;
-		me.wrapper.toggle(false);
-		wn.model.clear_doc(me.doc.doctype, me.doc.name);
-		me.frm.dirty();
-		me.grid.refresh();
+		if(this.grid.is_editable()) {
+			var me = this;
+			me.wrapper.toggle(false);
+			wn.model.clear_doc(me.doc.doctype, me.doc.name);
+			me.frm.script_manager.trigger(me.grid.df.fieldname + "_remove", me.doc.doctype, me.doc.name);
+			me.frm.dirty();
+			me.grid.refresh();
+		}
 	},
 	insert: function(show) {
 		var idx = this.doc.idx;