fix: handle empty list as filters
This commit is contained in:
parent
5bc5ff100b
commit
543458b473
2 changed files with 9 additions and 1 deletions
|
|
@ -111,7 +111,7 @@ class Engine:
|
|||
self.apply_dict_filters(filters)
|
||||
|
||||
elif isinstance(filters, (list, tuple)):
|
||||
if all(isinstance(d, (str, int)) for d in filters):
|
||||
if all(isinstance(d, (str, int)) for d in filters) and len(filters) > 0:
|
||||
self.apply_dict_filters({"name": ("in", filters)})
|
||||
else:
|
||||
for filter in filters:
|
||||
|
|
|
|||
|
|
@ -299,6 +299,14 @@ class TestQuery(FrappeTestCase):
|
|||
),
|
||||
)
|
||||
|
||||
self.assertEqual(
|
||||
frappe.qb.get_query(
|
||||
"DocType",
|
||||
filters=[],
|
||||
).get_sql(),
|
||||
"SELECT `name` FROM `tabDocType`".replace("`", '"' if frappe.db.db_type == "postgres" else "`"),
|
||||
)
|
||||
|
||||
def test_implicit_join_query(self):
|
||||
self.maxDiff = None
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue