From 54776f796bbd369c445b697ec95587f9a8773e01 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Sat, 23 Mar 2024 20:05:56 +0530 Subject: [PATCH] perf: dont set defaults unless required (#25626) On site with many signups this causes cache trashing because every signup clears cache. --- frappe/core/doctype/user/user.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/frappe/core/doctype/user/user.py b/frappe/core/doctype/user/user.py index 3d38348121..2d1583a81c 100644 --- a/frappe/core/doctype/user/user.py +++ b/frappe/core/doctype/user/user.py @@ -171,7 +171,8 @@ class User(Document): self.validate_username() self.remove_disabled_roles() self.validate_user_email_inbox() - ask_pass_update() + if self.user_emails: + ask_pass_update() self.validate_allowed_modules() self.validate_user_image() self.set_time_zone()