From 54b36e8604eed2538d12afddf9dabcc78ce4a54e Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Sun, 16 Jul 2023 12:14:21 +0530 Subject: [PATCH] perf: lazy load tag list for awesome bar In last 7 days not a single person has used this feature on FC (based on endpoint logs). fix: When user knowingly triggers by typing text starting with `#` we fire request to get tags lazily. --- frappe/public/js/frappe/ui/toolbar/awesome_bar.js | 1 - frappe/public/js/frappe/ui/toolbar/tag_utils.js | 5 +++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/ui/toolbar/awesome_bar.js b/frappe/public/js/frappe/ui/toolbar/awesome_bar.js index 4a3c88403f..5f01edf578 100644 --- a/frappe/public/js/frappe/ui/toolbar/awesome_bar.js +++ b/frappe/public/js/frappe/ui/toolbar/awesome_bar.js @@ -127,7 +127,6 @@ frappe.search.AwesomeBar = class AwesomeBar { } }); frappe.search.utils.setup_recent(); - frappe.tags.utils.fetch_tags(); } add_help() { diff --git a/frappe/public/js/frappe/ui/toolbar/tag_utils.js b/frappe/public/js/frappe/ui/toolbar/tag_utils.js index 29a0864036..ae1aa97670 100644 --- a/frappe/public/js/frappe/ui/toolbar/tag_utils.js +++ b/frappe/public/js/frappe/ui/toolbar/tag_utils.js @@ -8,6 +8,11 @@ frappe.tags.utils = { txt = txt.slice(1); let out = []; + if (!frappe.tags.tags) { + frappe.tags.utils.fetch_tags(); + return []; + } + for (let i in frappe.tags.tags) { let tag = frappe.tags.tags[i]; let level = frappe.search.utils.fuzzy_search(txt, tag);