From 5581f960da2fcbe9e3c867269691a9d336d1c95a Mon Sep 17 00:00:00 2001
From: Suraj Shetty <surajshetty3416@gmail.com>
Date: Wed, 14 Jun 2023 11:29:22 +0530
Subject: [PATCH] chore: Update node version requirement in build config

---
 .github/workflows/linters.yml                | 2 +-
 .github/workflows/on_release.yml             | 2 +-
 .github/workflows/patch-mariadb-tests.yml    | 2 +-
 .github/workflows/publish-assets-develop.yml | 2 +-
 .github/workflows/server-tests.yml           | 2 +-
 .github/workflows/ui-tests.yml               | 2 +-
 frappe/build.py                              | 4 ++--
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml
index c563f9e43f..481041ed68 100644
--- a/.github/workflows/linters.yml
+++ b/.github/workflows/linters.yml
@@ -25,7 +25,7 @@ jobs:
           fetch-depth: 200
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           check-latest: true
 
       - name: Check commit titles
diff --git a/.github/workflows/on_release.yml b/.github/workflows/on_release.yml
index 851b5b1d6a..c17a7c6639 100644
--- a/.github/workflows/on_release.yml
+++ b/.github/workflows/on_release.yml
@@ -22,7 +22,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
 
       - uses: actions/setup-python@v4
         with:
diff --git a/.github/workflows/patch-mariadb-tests.yml b/.github/workflows/patch-mariadb-tests.yml
index 3311f5235e..87cd530538 100644
--- a/.github/workflows/patch-mariadb-tests.yml
+++ b/.github/workflows/patch-mariadb-tests.yml
@@ -71,7 +71,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           check-latest: true
 
       - name: Add to Hosts
diff --git a/.github/workflows/publish-assets-develop.yml b/.github/workflows/publish-assets-develop.yml
index 4feaebe15d..f42c3bc55c 100644
--- a/.github/workflows/publish-assets-develop.yml
+++ b/.github/workflows/publish-assets-develop.yml
@@ -16,7 +16,7 @@ jobs:
           path: 'frappe'
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
       - uses: actions/setup-python@v4
         with:
           python-version: '3.11'
diff --git a/.github/workflows/server-tests.yml b/.github/workflows/server-tests.yml
index 8ae0be0197..f5eac8e380 100644
--- a/.github/workflows/server-tests.yml
+++ b/.github/workflows/server-tests.yml
@@ -90,7 +90,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           check-latest: true
 
       - name: Add to Hosts
diff --git a/.github/workflows/ui-tests.yml b/.github/workflows/ui-tests.yml
index 1b88bc73ce..bea00748e9 100644
--- a/.github/workflows/ui-tests.yml
+++ b/.github/workflows/ui-tests.yml
@@ -78,7 +78,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           check-latest: true
 
       - name: Add to Hosts
diff --git a/frappe/build.py b/frappe/build.py
index 18ceff1d7a..e914d977fc 100644
--- a/frappe/build.py
+++ b/frappe/build.py
@@ -274,8 +274,8 @@ def watch(apps=None):
 def check_node_executable():
 	node_version = Version(subprocess.getoutput("node -v")[1:])
 	warn = "⚠️ "
-	if node_version.major < 14:
-		click.echo(f"{warn} Please update your node version to 14")
+	if node_version.major < 18:
+		click.echo(f"{warn} Please update your node version to 18")
 	if not shutil.which("yarn"):
 		click.echo(f"{warn} Please install yarn using below command and try again.\nnpm install -g yarn")
 	click.echo()