vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

test(db_query): assert self-referential Link joins don't collide on alias

Browse source 
Mirrors test_ambiguous_linked_tables but with a DocType whose Link
fields point back to itself, covering the path where pypika's '2'
auto-alias collides on the second self-join.
This commit is contained in:
vijayanrxbb 2026-04-24 20:02:43 +05:30 • committed by AarDG10
parent 383b24e0f9
commit 55e342bbd5
1 changed files with 60 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
frappe/tests/test_db_query.py
View file

@ -1179,6 +1179,66 @@ class TestDBQuery(IntegrationTestCase):
data = get() data = get()
self.assertEqual(len(data["values"]), 1) self.assertEqual(len(data["values"]), 1)
def test_self_referential_link_joins(self):
from frappe.desk.reportview import get
if not frappe.db.exists("DocType", "Self Linked DocType"):
frappe.get_doc(
{
"doctype": "DocType",
"custom": 1,
"module": "Custom",
"name": "Self Linked DocType",
"naming_rule": "Random",
"autoname": "hash",
"fields": [
{
"label": "Title",
"fieldname": "title",
"fieldtype": "Data",
},
{
"label": "Parent Ref",
"fieldname": "parent_ref",
"fieldtype": "Link",
"options": "Self Linked DocType",
},
{
"label": "Sibling Ref",
"fieldname": "sibling_ref",
"fieldtype": "Link",
"options": "Self Linked DocType",
},
],
}
).insert()
else:
frappe.db.delete("Self Linked DocType")
root = frappe.get_doc({"doctype": "Self Linked DocType", "title": "Root"}).insert()
sibling = frappe.get_doc({"doctype": "Self Linked DocType", "title": "Sibling"}).insert()
frappe.get_doc(
{
"doctype": "Self Linked DocType",
"title": "Child",
"parent_ref": root.name,
"sibling_ref": sibling.name,
}
).insert()
frappe.form_dict.doctype = "Self Linked DocType"
frappe.form_dict.fields = [
"`tabSelf Linked DocType`.`name`",
"`tabSelf Linked DocType`.`parent_ref`",
"`tabSelf Linked DocType`.`sibling_ref`",
"parent_ref.title as parent_title",
"sibling_ref.title as sibling_title",
]
# Shouldn't raise pymysql.err.OperationalError: (1066, "Not unique table/alias: 'tabSelf Linked DocType2'")
data = get()
self.assertEqual(len(data["values"]), 3)
def test_select_star_expansion(self): def test_select_star_expansion(self):
count = frappe.get_list("Language", [{"SUM": 1}, {"COUNT": "*"}], as_list=1, order_by=None)[0] count = frappe.get_list("Language", [{"SUM": 1}, {"COUNT": "*"}], as_list=1, order_by=None)[0]
self.assertEqual(count[0], frappe.db.count("Language")) self.assertEqual(count[0], frappe.db.count("Language"))