From 5604b090c0b2e891a19d1b122ea2e30ff23b543d Mon Sep 17 00:00:00 2001
From: Samuel Danieli <23150094+scdanieli@users.noreply.github.com>
Date: Mon, 27 Jun 2022 22:15:23 +0200
Subject: [PATCH] feat: enable further translations

---
 frappe/public/js/frappe/ui/sort_selector.html           | 2 +-
 frappe/public/js/frappe/ui/sort_selector.js             | 2 +-
 frappe/public/js/frappe/ui/toolbar/toolbar.js           | 2 +-
 frappe/public/js/frappe/utils/dashboard_utils.js        | 4 +++-
 frappe/public/js/frappe/views/kanban/kanban_column.html | 2 +-
 5 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/frappe/public/js/frappe/ui/sort_selector.html b/frappe/public/js/frappe/ui/sort_selector.html
index 6f79f986a1..4e1945c46c 100644
--- a/frappe/public/js/frappe/ui/sort_selector.html
+++ b/frappe/public/js/frappe/ui/sort_selector.html
@@ -2,7 +2,7 @@
 	<div class="btn-group">
 		<button class="btn btn-default btn-sm btn-order"
 			data-value="{{ sort_order }}"
-			title="{{ sort_order==="desc" ? "descending" : "ascending" }}">
+			title="{{ sort_order==="desc" ? __("descending") : __("ascending") }}">
 			<span class="sort-order">
 				<svg class="icon icon-sm">
 					<use href="#icon-{{ sort_order==="desc" ? "sort-descending" : "sort-ascending" }}"></use>
diff --git a/frappe/public/js/frappe/ui/sort_selector.js b/frappe/public/js/frappe/ui/sort_selector.js
index 837454ed09..52abad95d4 100644
--- a/frappe/public/js/frappe/ui/sort_selector.js
+++ b/frappe/public/js/frappe/ui/sort_selector.js
@@ -25,7 +25,7 @@ frappe.ui.SortSelector = class SortSelector {
 		this.wrapper.find('.btn-order').on('click', function() {
 			let btn = $(this);
 			const order = $(this).attr('data-value') === 'desc' ? 'asc' : 'desc';
-			const title = $(this).attr('data-value' )=== 'desc' ? 'ascending' : 'descending';
+			const title = $(this).attr('data-value' )=== 'desc' ? __('ascending') : __('descending');
 
 			btn.attr('data-value', order);
 			btn.attr('title', title);
diff --git a/frappe/public/js/frappe/ui/toolbar/toolbar.js b/frappe/public/js/frappe/ui/toolbar/toolbar.js
index e4359b5efb..b6823efcf4 100644
--- a/frappe/public/js/frappe/ui/toolbar/toolbar.js
+++ b/frappe/public/js/frappe/ui/toolbar/toolbar.js
@@ -97,7 +97,7 @@ frappe.ui.toolbar.Toolbar = class {
 				$("<a>", {
 					href: url,
 					class: "dropdown-item",
-					text: link.label,
+					text: __(link.label),
 					target: "_blank"
 				}).appendTo($help_links);
 			}
diff --git a/frappe/public/js/frappe/utils/dashboard_utils.js b/frappe/public/js/frappe/utils/dashboard_utils.js
index c4b094b216..1818342220 100644
--- a/frappe/public/js/frappe/utils/dashboard_utils.js
+++ b/frappe/public/js/frappe/utils/dashboard_utils.js
@@ -16,7 +16,7 @@ frappe.dashboard_utils = {
 					<a data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
 						<button class="btn btn-secondary btn-xs">
 			 				${icon_html}
-							<span class="filter-label">${filter.label}</span>
+							<span class="filter-label">${__(filter.label)}</span>
 							${frappe.utils.icon('select', 'xs')}
 						</button>
 				</a>`;
@@ -24,10 +24,12 @@ frappe.dashboard_utils = {
 
 			if (filter.fieldnames) {
 				options_html = filter.options.map((option, i) =>
+					// TODO: Make option translatable - be careful, since the text of the a tag is later used to perform some action
 					`<li>
 						<a class="dropdown-item" data-fieldname="${filter.fieldnames[i]}">${option}</a>
 					</li>`).join('');
 			} else {
+				// TODO: Make option translatable - be careful, since the text of the a tag is later used to perform some action
 				options_html = filter.options.map( option => `<li><a class="dropdown-item">${option}</a></li>`).join('');
 			}
 
diff --git a/frappe/public/js/frappe/views/kanban/kanban_column.html b/frappe/public/js/frappe/views/kanban/kanban_column.html
index 9c9f1eede0..5e6b6e1e7b 100644
--- a/frappe/public/js/frappe/views/kanban/kanban_column.html
+++ b/frappe/public/js/frappe/views/kanban/kanban_column.html
@@ -17,7 +17,7 @@
 	</div>
 	<div class="add-card">
 		<div class="ellipsis">
-			+ {{ __("Add " + doctype) }}
+            + {{ __("Add {0}", [__(doctype)]) }}
 		</div>
 	</div>
 	<div class="kanban-card new-card-area">