vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Merge pull request #8709 from hrwX/list_form_int_fix

Browse source 
fix: convert number to string if title_field is Int
This commit is contained in:
mergify[bot] 2019-11-04 07:46:44 +00:00 • committed by GitHub
commit 56e07fc2a3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
frappe/public/js/frappe/form/toolbar.js
View file

@ -30,7 +30,8 @@ frappe.ui.form.Toolbar = Class.extend({
},
set_title: function() {
if(this.frm.meta.title_field) {
var title = strip_html((this.frm.doc[this.frm.meta.title_field] || "").trim() || this.frm.docname);
let title_field = (this.frm.doc[this.frm.meta.title_field] || "").toString().trim();
var title = strip_html(title_field || this.frm.docname);
if(this.frm.doc.__islocal || title === this.frm.docname || this.frm.meta.autoname==="hash") {
this.page.set_title_sub("");
} else {

2
frappe/public/js/frappe/list/list_view.js
View file

@ -719,7 +719,7 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
let user = frappe.session.user;
let subject_field = this.columns[0].df;
let value = doc[subject_field.fieldname] || doc.name;
let subject = strip_html(value);
let subject = strip_html(value.toString());
let escaped_subject = frappe.utils.escape_html(subject);
const liked_by = JSON.parse(doc._liked_by || '[]');