From 5874d6bf1238b820f385d9daaa89176b9c83b454 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Wed, 15 Jan 2025 18:33:24 +0530 Subject: [PATCH] perf: Add prefix index for file_url (#29185) Currently it's full table scan, that too on a TEXT field filter. It's used for finding file docs when `fid` isn't specified. No idea where we are STILL having private file URLs without fids. In any case, this is still required. --- frappe/core/doctype/file/file.json | 2 +- frappe/core/doctype/file/file.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/frappe/core/doctype/file/file.json b/frappe/core/doctype/file/file.json index 166c3fa4be..922961f0e3 100644 --- a/frappe/core/doctype/file/file.json +++ b/frappe/core/doctype/file/file.json @@ -190,7 +190,7 @@ "icon": "fa fa-file", "idx": 1, "links": [], - "modified": "2024-05-09 11:46:42.917146", + "modified": "2025-01-15 11:46:42.917146", "modified_by": "Administrator", "module": "Core", "name": "File", diff --git a/frappe/core/doctype/file/file.py b/frappe/core/doctype/file/file.py index c147f70818..306bee91d1 100755 --- a/frappe/core/doctype/file/file.py +++ b/frappe/core/doctype/file/file.py @@ -797,6 +797,7 @@ class File(Document): def on_doctype_update(): frappe.db.add_index("File", ["attached_to_doctype", "attached_to_name"]) + frappe.db.add_index("File", ["file_url(100)"]) def has_permission(doc, ptype=None, user=None, debug=False):