vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix(router): handle exceptions when trying to JSONify a circular reference

Browse source 
router.js:373 Uncaught (in promise) TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'frappe.ui.form.Form'
    |     property 'grids' -> object with constructor 'Array'
    |     index 0 -> object with constructor 'frappe.ui.form.ControlTable'
    --- property 'frm' closes the circle
    at JSON.stringify (<anonymous>)
    at router.js:373:65
    at Array.map (<anonymous>)
    at Promise.finally.frappe.route_flags (router.js:373:7)
    at new Promise (<anonymous>)
    at Object.set_route (router.js:360:10)
    at frappe.set_route (router.js:567:33)
    at frappe.ui.form.Form.print_doc (form.js:1276:10)
    at HTMLButtonElement.<anonymous> (toolbar.js:330:14)
    at HTMLButtonElement.dispatch (jquery.js:5135:27)
    at Rt.handle (jquery.js:4939:28)
    at HTMLButtonElement.i (helpers.ts:95:1)

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2023-11-27 17:45:28 +05:30
parent 6330c1b209
commit 58fb1d5f0c
No known key found for this signature in database
GPG key ID: 9DCC61E211BF645F
1 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
frappe/public/js/frappe/router.js
View file

@ -368,11 +368,17 @@ frappe.router = {
window.open(sub_path, "_blank");
frappe.open_in_new_tab = false;
} else {
const route_options = frappe.route_options || {};
const query_params = Object.entries(route_options)
.map(([key, value]) => `${key}=` + encodeURIComponent(JSON.stringify(value)))
.join("&");
this.push_state(sub_path, query_params ? `?${query_params}` : "");
try {
const route_options = frappe.route_options || {};
const query_params = Object.entries(route_options)
.map(
([key, value]) => `${key}=` + encodeURIComponent(JSON.stringify(value))
)
.join("&");
this.push_state(sub_path, query_params ? `?${query_params}` : "");
} catch (e) {
this.push_state(sub_path);
}
}
setTimeout(() => {
frappe.after_ajax &&