vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

perf: do not validate user on session resume (#29074)

Browse source 
* fix: Consume sid from arguments

* perf: do not validate user on resume

Errr, why would we ever need to validate if user with active session is
"disabled"?

When active user is disabled, their sessions are wiped from cache and DB.
This commit is contained in:
Ankush Menat 2025-01-07 18:22:23 +05:30 • committed by GitHub
parent 77c9c9ee93
commit 59309f8164
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
frappe/sessions.py
View file

@ -205,7 +205,9 @@ class Session:
__slots__ = ("_update_in_cache", "data", "full_name", "sid", "time_diff", "user", "user_type")
def __init__(self, user, resume=False, full_name=None, user_type=None):
self.sid = cstr(frappe.form_dict.get("sid") or unquote(frappe.request.cookies.get("sid", "Guest")))
self.sid = cstr(
frappe.form_dict.pop("sid", None) or unquote(frappe.request.cookies.get("sid", "Guest"))
)
self.user = user
self.user_type = user_type
self.full_name = full_name
@ -301,7 +303,6 @@ class Session:
if data:
self.data.update({"data": data, "user": data.user, "sid": self.sid})
self.user = data.user
self.validate_user()
validate_ip_address(self.user)
else:
self.start_as_guest()