Merge pull request #31867 from sokumon/dont-send-email-to-creator

fix: configure if email is sent to creator
This commit is contained in:
Soham Kulkarni 2025-03-24 12:44:07 +05:30 committed by GitHub
commit 5948a4d941
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 13 additions and 3 deletions

View file

@ -299,7 +299,8 @@ def get_users_next_action_data(transitions, doc):
filtered_users = [
user for user in users if has_approval_access(user, doc, transition) and user_has_permission(user)
]
if doc.get("owner") in filtered_users and not transition.get("send_email_to_creator"):
filtered_users.remove(doc.get("owner"))
for user in filtered_users:
if not user_data_map.get(user):
user_data_map[user] = frappe._dict(

View file

@ -11,6 +11,7 @@
"next_state",
"allowed",
"allow_self_approval",
"send_email_to_creator",
"conditions",
"condition",
"column_break_7",
@ -91,12 +92,19 @@
"fieldtype": "Data",
"hidden": 1,
"label": "Workflow Builder ID"
},
{
"default": "0",
"depends_on": "eval: doc.allow_self_approval == 1",
"fieldname": "send_email_to_creator",
"fieldtype": "Check",
"label": "Send Email To Creator"
}
],
"idx": 1,
"istable": 1,
"links": [],
"modified": "2024-03-23 16:04:05.493534",
"modified": "2025-03-24 02:47:44.188152",
"modified_by": "Administrator",
"module": "Workflow",
"name": "Workflow Transition",
@ -105,4 +113,4 @@
"sort_field": "creation",
"sort_order": "DESC",
"states": []
}
}

View file

@ -22,6 +22,7 @@ class WorkflowTransition(Document):
parent: DF.Data
parentfield: DF.Data
parenttype: DF.Data
send_email_to_creator: DF.Check
state: DF.Link
workflow_builder_id: DF.Data | None
# end: auto-generated types