From 80fd42aba29bd965bd711c4639dd74e13b0b67ff Mon Sep 17 00:00:00 2001 From: Suraj Shetty Date: Thu, 12 Dec 2019 11:35:22 +0530 Subject: [PATCH] fix: Hidden columns should be hidden even after refresh --- frappe/public/js/frappe/views/reports/query_report.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/views/reports/query_report.js b/frappe/public/js/frappe/views/reports/query_report.js index 0771306298..c7e976306d 100644 --- a/frappe/public/js/frappe/views/reports/query_report.js +++ b/frappe/public/js/frappe/views/reports/query_report.js @@ -452,6 +452,7 @@ frappe.views.QueryReport = class QueryReport extends frappe.views.BaseList { render_datatable() { let data = this.data; + let columns = this.columns.filter((col) => !col.hidden); if (this.raw_data.add_total_row) { data = data.slice(); @@ -460,10 +461,10 @@ frappe.views.QueryReport = class QueryReport extends frappe.views.BaseList { if (this.datatable) { this.datatable.options.treeView = this.tree_report; - this.datatable.refresh(data, this.columns); + this.datatable.refresh(data, columns); } else { let datatable_options = { - columns: this.columns.filter((col) => !col.hidden), + columns: columns, data: data, inlineFilters: true, treeView: this.tree_report,