From 5993c42d043a5edef4d09d1cccc45552f14e9dbf Mon Sep 17 00:00:00 2001 From: Himanshu Warekar Date: Fri, 5 Jul 2019 09:24:54 +0530 Subject: [PATCH] fix: validate if client is and secret both set --- .../doctype/google_settings/google_settings.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/frappe/integrations/doctype/google_settings/google_settings.py b/frappe/integrations/doctype/google_settings/google_settings.py index 50713f187c..9e717246a8 100644 --- a/frappe/integrations/doctype/google_settings/google_settings.py +++ b/frappe/integrations/doctype/google_settings/google_settings.py @@ -3,8 +3,12 @@ # For license information, please see license.txt from __future__ import unicode_literals -# import frappe +import frappe +from frappe import _ from frappe.model.document import Document class GoogleSettings(Document): - pass \ No newline at end of file + + def validate(self): + if (self.client_id and not self.client_secret) or (not self.client_id and self.client_secret): + frappe.throw(_("Set Client ID and Client Secret for Google Integrations."))