From 5a1cac6bc3d4399ce4c9db1f241cb3cd87d33158 Mon Sep 17 00:00:00 2001 From: Sumit Bhanushali Date: Sat, 29 Jun 2024 00:00:59 +0530 Subject: [PATCH] perf: removed redundant db calls Co-authored-by: gavin --- frappe/core/doctype/version/version.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/frappe/core/doctype/version/version.py b/frappe/core/doctype/version/version.py index fc4da86e9f..f68d4abd84 100644 --- a/frappe/core/doctype/version/version.py +++ b/frappe/core/doctype/version/version.py @@ -155,10 +155,8 @@ def get_diff(old, new, for_child=False, compare_cancelled=False): link_meta = frappe.get_meta(field_meta.options) # Show title field value if field is Link and show_title_field_in_link is True - if link_meta.show_title_field_in_link: - title_field = link_meta.get_title_field() - old_title_val = frappe.get_value(field_meta.options, old_value, title_field) - new_title_val = frappe.get_value(field_meta.options, new_value, title_field) + if link_meta.show_title_field_in_link and ((title_field := link_meta.get_title_field()) != "name"): + old_title_val, new_title_val = frappe.db.get_values(field_meta.options, {"name": ("in", (old_value, new_value))}, title_field, pluck=True) out.changed.append((df.fieldname, old_title_val, new_title_val)) continue out.changed.append((df.fieldname, old_value, new_value))