From 5a8c89ccb4556ee46b99e36738874bc4e32cd4fe Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Tue, 30 Mar 2021 16:37:53 +0530 Subject: [PATCH] fix(minor): tests (cherry picked from commit 82399ddfba3d03b08491aa82d23aec45df9e5663) --- frappe/desk/reportview.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/frappe/desk/reportview.py b/frappe/desk/reportview.py index fd61224b19..e9914ef4cf 100644 --- a/frappe/desk/reportview.py +++ b/frappe/desk/reportview.py @@ -59,7 +59,6 @@ def validate_args(data): return data def validate_fields(data): - expand_fields(data) if update_wildcard_field_param(data): # no need to validate wildcard fields return @@ -126,11 +125,6 @@ def setup_group_by(data): data.pop('aggregate_on') data.pop('aggregate_function') -def expand_fields(data): - if ((isinstance(data.fields, string_types) and data.fields == "*") - or (isinstance(data.fields, (list, tuple)) and len(data.fields) == 1 and data.fields[0] == "*")): - data.fields = frappe.db.get_table_columns(data.doctype) - def raise_invalid_field(fieldname): frappe.throw(_('Field not permitted in query') + ': {0}'.format(fieldname), frappe.DataError)