vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: remove depends_on hack for child tables (#37909)

Browse source
This commit is contained in:
Sagar Vora 2026-03-11 02:08:26 +00:00 • committed by GitHub
parent 088ae90c9f
commit 5bb27bda8d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 2 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
frappe/core/doctype/docfield/docfield.json
View file

@ -338,7 +338,7 @@
},
{
"default": "0",
"depends_on": "eval: parent.is_submittable",
"depends_on": "eval: parent.is_submittable || parent.istable",
"fieldname": "allow_on_submit",
"fieldtype": "Check",
"label": "Allow on Submit",
@ -647,7 +647,7 @@
"index_web_pages_for_search": 1,
"istable": 1,
"links": [],
"modified": "2026-02-06 15:13:03.688027",
"modified": "2026-03-10 21:39:58.400441",
"modified_by": "Administrator",
"module": "Core",
"name": "DocField",

3
frappe/public/js/form_builder/utils.js
View file

@ -214,9 +214,6 @@ export function evaluate_depends_on_value(expression, doc) {
} else if (expression.substr(0, 5) == "eval:") {
try {
out = frappe.utils.eval(expression.substr(5), { doc, parent });
if (parent && parent.istable && expression.includes("is_submittable")) {
out = true;
}
} catch (e) {
frappe.throw(__('Invalid "depends_on" expression'));
}

3
frappe/public/js/frappe/form/grid_row.js
View file

@ -836,9 +836,6 @@ export default class GridRow {
} else if (expression.substr(0, 5) == "eval:") {
try {
out = frappe.utils.eval(expression.substr(5), { doc, parent });
if (parent && parent.istable && expression.includes("is_submittable")) {
out = true;
}
} catch (e) {
frappe.throw(__('Invalid "depends_on" expression'));
}

3
frappe/public/js/frappe/form/layout.js
View file

@ -802,9 +802,6 @@ frappe.ui.form.Layout = class Layout {
} else if (expression.substr(0, 5) == "eval:") {
try {
out = frappe.utils.eval(expression.substr(5), { doc, parent });
if (parent && parent.istable && expression.includes("is_submittable")) {
out = true;
}
} catch (e) {
frappe.throw(__('Invalid "depends_on" expression'));
}

3
frappe/public/js/frappe/form/save.js
View file

@ -210,9 +210,6 @@ frappe.ui.form.check_mandatory = function (frm) {
} else if (expression.substr(0, 5) == "eval:") {
try {
out = frappe.utils.eval(expression.substr(5), { doc, parent });
if (parent && parent.istable && expression.includes("is_submittable")) {
out = true;
}
} catch (e) {
frappe.throw(__('Invalid "mandatory_depends_on" expression'));
}

3
frappe/public/js/frappe/views/reports/report_view.js
View file

@ -763,9 +763,6 @@ frappe.views.ReportView = class ReportView extends frappe.views.ListView {
} else if (expression.substr(0, 5) == "eval:") {
try {
out = frappe.utils.eval(expression.substr(5), { doc: data });
if (parent && parent.istable && expression.includes("is_submittable")) {
out = true;
}
} catch (e) {
frappe.throw(__('Invalid "depends_on" expression'));
}