vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: wait for all filters to be set, dont refresh report while setting filters

Browse source
This commit is contained in:
Sagar Vora 2025-06-11 18:34:06 +05:30
parent 1b9d642089
commit 5c1f230bca
1 changed files with 6 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
frappe/public/js/frappe/views/reports/query_report.js
View file

@ -402,9 +402,11 @@ frappe.views.QueryReport = class QueryReport extends frappe.views.BaseList {
return frappe.run_serially([
() => this.setup_filters(),
() => (this._no_refresh = true),
() => this.set_route_filters(route_options),
() => this.page.clear_custom_actions(),
() => this.report_settings.onload && this.report_settings.onload(this),
() => (this._no_refresh = false),
() => this.refresh(),
]);
}
@ -565,12 +567,8 @@ frappe.views.QueryReport = class QueryReport extends frappe.views.BaseList {
if (f.on_change) {
f.on_change(this);
} else {
if (this.prepared_report) {
this.reset_report_view();
} else if (!this._no_refresh) {
this.refresh(true);
}
} else if (!this._no_refresh) {
this.refresh(true);
}
};
@ -669,13 +667,13 @@ frappe.views.QueryReport = class QueryReport extends frappe.views.BaseList {
this.prepared_report_name = route_options.prepared_report_name;
const promises = filters_to_set.map((f) => {
return () => {
return async () => {
let value = route_options[f.df.fieldname];
if (typeof value === "string" && value[0] === "[") {
// multiselect array
value = JSON.parse(value);
}
f.set_value(value);
await f.set_value(value);
};
});
promises.push(() => {
@ -2120,12 +2118,6 @@ frappe.views.QueryReport = class QueryReport extends frappe.views.BaseList {
</div>`;
}
reset_report_view() {
this.hide_status();
this.toggle_nothing_to_show(true);
this.refresh();
}
toggle_nothing_to_show(flag) {
let message =
this.prepared_report && !this.prepared_report_document