From cc1aa640074df6a64ea327eacbd2f91e041bc912 Mon Sep 17 00:00:00 2001 From: krantheman Date: Thu, 5 Feb 2026 17:38:52 +0700 Subject: [PATCH 1/2] fix: grid row selection on touch --- frappe/public/js/frappe/form/grid.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/form/grid.js b/frappe/public/js/frappe/form/grid.js index 1bf448ef25..6b5ade51b0 100644 --- a/frappe/public/js/frappe/form/grid.js +++ b/frappe/public/js/frappe/form/grid.js @@ -195,7 +195,10 @@ export default class Grid { } setup_check() { - this.wrapper.on("click", ".grid-row-check", (e) => { + this.wrapper.on("click touchend", ".grid-row-check", (e) => { + e.stopPropagation(); + if (e.type === "touchend") return; + const $check = $(e.currentTarget); const checked = $check.prop("checked"); const is_select_all = $check.parents(".grid-heading-row:first").length !== 0; From 58b61343c48baac112e4763296dd13f55d5a995b Mon Sep 17 00:00:00 2001 From: krantheman Date: Fri, 6 Feb 2026 18:52:45 +0700 Subject: [PATCH 2/2] fix: stop propagation only when necessary --- frappe/public/js/frappe/form/grid.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/form/grid.js b/frappe/public/js/frappe/form/grid.js index 6b5ade51b0..d39896767c 100644 --- a/frappe/public/js/frappe/form/grid.js +++ b/frappe/public/js/frappe/form/grid.js @@ -196,8 +196,10 @@ export default class Grid { setup_check() { this.wrapper.on("click touchend", ".grid-row-check", (e) => { - e.stopPropagation(); - if (e.type === "touchend") return; + if (e.type === "touchend") { + e.stopPropagation(); + return; + } const $check = $(e.currentTarget); const checked = $check.prop("checked");