From 5d270b9f67b8b3e757de3efda15288048db685b3 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Thu, 27 Feb 2025 08:11:53 +0000 Subject: [PATCH] fix: Cache thrashing in workspace code (#31446) (#31448) if result is `[]` then it ignores cache and keeps hitting DB for no reason. (cherry picked from commit 20b63f3252f9b23655e34ca830cff426ad5a50a3) Co-authored-by: Ankush Menat --- frappe/desk/desktop.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/desk/desktop.py b/frappe/desk/desktop.py index 738de62108..ec57ef8e96 100644 --- a/frappe/desk/desktop.py +++ b/frappe/desk/desktop.py @@ -86,7 +86,7 @@ class Workspace: def get_cached(self, cache_key, fallback_fn): value = frappe.cache.get_value(cache_key, user=frappe.session.user) - if value: + if value is not None: return value value = fallback_fn()