vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Show zero rate column in the print if print_hide_if_no_value is disabled (#4694)

Browse source
This commit is contained in:
rohitwaghchaure 2017-12-28 12:55:21 +05:30 • committed by Nabin Hait
parent fa3c2a219d
commit 5d6fdb8f05
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
frappe/www/printview.py
View file

@ -398,7 +398,7 @@ def get_visible_columns(data, table_meta, df):
doc = data[0] or frappe.new_doc(df.options)
def add_column(col_df):
return is_visible(col_df, doc) \
and column_has_value(data, col_df.get("fieldname"))
and column_has_value(data, col_df.get("fieldname"), col_df)
if df.get("visible_columns"):
# columns specified by column builder
@ -418,10 +418,13 @@ def get_visible_columns(data, table_meta, df):
return columns
def column_has_value(data, fieldname):
def column_has_value(data, fieldname, col_df):
"""Check if at least one cell in column has non-zero and non-blank value"""
has_value = False
if col_df.fieldtype in ['Float', 'Currency'] and not col_df.print_hide_if_no_value:
return True
for row in data:
value = row.get(fieldname)
if value: