vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: validate before saving

Browse source
This commit is contained in:
Shariq Ansari 2023-07-10 11:15:47 +05:30
parent 63fa87d2b4
commit 5db44e858b
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frappe/core/doctype/doctype/doctype.js
View file

@ -5,7 +5,11 @@ frappe.ui.form.on("DocType", {
before_save: function (frm) {
let form_builder = frappe.form_builder;
if (form_builder?.store) {
form_builder.store.update_fields();
let fields = form_builder.store.update_fields();
if (!fields.length) {
frappe.throw(__("Error occurred while saving the form."));
}
frm.refresh_fields();
}
},

4
frappe/public/js/form_builder/store.js
View file

@ -142,6 +142,10 @@ export const useStore = defineStore("form-builder-store", () => {
function validate_fields(fields, is_table) {
fields = scrub_field_names(fields);
if (!fields.length) {
frappe.throw(__("DocType must have atleast one field"));
}
let not_allowed_in_list_view = ["Attach Image", ...frappe.model.no_value_type];
if (is_table) {
not_allowed_in_list_view = not_allowed_in_list_view.filter((f) => f != "Button");