From 5e1146e216770d47f0d12f3f20e055cf5d53ada4 Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Mon, 2 Dec 2024 13:30:49 +0530 Subject: [PATCH] fix(installer): don't set defaults for `frappe.flags.root_username` Its set anyway when calling `setup_database()` (inside `get_root_connection()`) Signed-off-by: Akhil Narang --- frappe/installer.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/frappe/installer.py b/frappe/installer.py index 662228355e..b930e03278 100644 --- a/frappe/installer.py +++ b/frappe/installer.py @@ -142,11 +142,6 @@ def install_db( if not db_type: db_type = frappe.conf.db_type - if not root_login and db_type == "mariadb": - root_login = "root" - elif not root_login and db_type == "postgres": - root_login = "postgres" - make_conf( db_name, site_config=site_config, @@ -159,8 +154,11 @@ def install_db( ) frappe.flags.in_install_db = True - frappe.flags.root_login = root_login - frappe.flags.root_password = root_password + if root_login: + frappe.flags.root_login = root_login + + if root_password: + frappe.flags.root_password = root_password if setup: setup_database(force, verbose, mariadb_user_host_login_scope)