From 5eabc7ebac6ead094194be7b4a57bd3a1e539e16 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Thu, 20 Mar 2025 11:19:20 +0530 Subject: [PATCH] fix: shutdown posthog after job (#31819) * fix: change log level A duplicate existing job is often a cause of concern. * fix: avoid waiting indefinitely in long-living processes --- frappe/utils/background_jobs.py | 4 ++-- frappe/utils/telemetry.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/frappe/utils/background_jobs.py b/frappe/utils/background_jobs.py index fa1c33f228..55ef61eeb6 100644 --- a/frappe/utils/background_jobs.py +++ b/frappe/utils/background_jobs.py @@ -115,7 +115,7 @@ def enqueue( frappe.throw(_("`job_id` paramater is required for deduplication.")) job = get_job(job_id) if job and job.get_status(refresh=False) in (JobStatus.QUEUED, JobStatus.STARTED): - frappe.logger().debug(f"Not queueing job {job.id} because it is in queue already") + frappe.logger().error(f"Not queueing job {job.id} because it is in queue already") return elif job: # delete job to avoid argument issues related to job args @@ -725,7 +725,7 @@ def flush_telemetry(): to push events.""" ph = getattr(frappe.local, "posthog", None) with suppress(Exception): - ph and ph.flush() + ph and ph.shutdown() def _check_queue_size(q: Queue): diff --git a/frappe/utils/telemetry.py b/frappe/utils/telemetry.py index ea25adae0a..0490d98aa0 100644 --- a/frappe/utils/telemetry.py +++ b/frappe/utils/telemetry.py @@ -51,7 +51,7 @@ def init_telemetry(): return with suppress(Exception): - frappe.local.posthog = Posthog(posthog_project_id, host=posthog_host) + frappe.local.posthog = Posthog(posthog_project_id, host=posthog_host, timeout=5, max_retries=3) def capture(event, app, **kwargs):