Merge pull request #842 from anandpdoshi/anand-september-11

Fixes to ToDo list avatar and tags for single types

frappe/core/doctype/todo/todo_list.html

@@ -23,7 +23,7 @@
 	</div>
 	<div class="col-xs-1 text-right" style="margin-bottom: 3px;">
 		<span class="filterable" data-filter="owner,=,{%= doc.owner %}">
-		{%= frappe.avatar(doc.assigned_to) %}
+		{%= frappe.avatar(doc.owner) %}
 		</span>
 	</div>
 </div>

frappe/model/create_new.py

@@ -89,5 +89,5 @@ def get_default_value(df, defaults, user_permissions, parent_doc):
 	elif df.fieldtype == "Time":
 		return nowtime()
 
-	elif (df.fieldtype == "Select" and df.options and df.options != "[Select]"):
+	elif (df.fieldtype == "Select" and df.options and df.options not in ("[Select]", "Loading...")):
 		return df.options.split("\n")[0]

frappe/model/document.py

@@ -80,7 +80,13 @@ class Document(BaseDocument):
 
 	def load_from_db(self):
 		if not getattr(self, "_metaclass", False) and self.meta.issingle:
-			self.update(frappe.db.get_singles_dict(self.doctype))
+			single_doc = frappe.db.get_singles_dict(self.doctype)
+			if not single_doc:
+				single_doc = frappe.new_doc(self.doctype).as_dict()
+				single_doc["name"] = self.doctype
+				del single_doc["__islocal"]
+
+			self.update(single_doc)
 			self.init_valid_columns()
 			self._fix_numeric_types()
 

frappe/public/build.json

@@ -107,6 +107,7 @@
 		"public/js/frappe/ui/tags.js",
 
 		"public/js/frappe/views/container.js",
+		"public/js/frappe/views/factory.js",
 		"public/js/frappe/views/pageview.js",
 		"public/js/frappe/views/doclistview.js",
 		"public/js/frappe/views/sidebar_stats.js",

frappe/public/js/frappe/form/footer.js

@@ -91,7 +91,7 @@ frappe.ui.form.Footer = Class.extend({
 			this.frm.attachments.refresh();
 			this.frm.comments.refresh();
 			this.frm.assign_to.refresh();
-			this.frm.tags.refresh();
+			this.frm.tags && this.frm.tags.refresh();
 		}
 	},
 });

frappe/public/js/frappe/model/create_new.js

@@ -66,7 +66,7 @@ $.extend(frappe.model, {
 					doc[f.fieldname] = v;
 					updated.push(f.fieldname);
 				} else if(f.fieldtype == "Select" && f.options
-					&& f.options!="[Select]") {
+					&& !in_list(["[Select]", "Loading..."], f.options)) {
 						doc[f.fieldname] = f.options.split("\n")[0];
 				}
 			}

frappe/public/js/frappe/views/container.js

@@ -73,34 +73,3 @@ frappe.views.Container = Class.extend({
 		return this.page;
 	}
 });
-
-frappe.views.Factory = Class.extend({
-	init: function(opts) {
-		$.extend(this, opts);
-	},
-	show: function() {
-		var page_name = frappe.get_route_str(),
-			me = this;
-		if(frappe.pages[page_name]) {
-			frappe.container.change_to(frappe.pages[page_name]);
-		} else {
-			var route = frappe.get_route();
-			if(route[1]) {
-				me.make(route);
-			} else {
-				frappe.show_not_found(route);
-			}
-		}
-	},
-	make_page: function(double_column) {
-		var page_name = frappe.get_route_str(),
-			page = frappe.container.add_page(page_name);
-
-		frappe.ui.make_app_page({
-			parent: page,
-			single_column: !double_column
-		});
-		frappe.container.change_to(page_name);
-		return page;
-	}
-})

frappe/public/js/frappe/views/factory.js

@@ -0,0 +1,36 @@
+// Copyright (c) 2013, Web Notes Technologies Pvt. Ltd. and Contributors
+// MIT License. See license.txt
+
+frappe.provide('frappe.pages');
+frappe.provide('frappe.views');
+
+frappe.views.Factory = Class.extend({
+	init: function(opts) {
+		$.extend(this, opts);
+	},
+	show: function() {
+		var page_name = frappe.get_route_str(),
+			me = this;
+		if(frappe.pages[page_name] && page_name.indexOf("Form/")===-1) {
+			frappe.container.change_to(frappe.pages[page_name]);
+		} else {
+			var route = frappe.get_route();
+			if(route[1]) {
+				me.make(route);
+			} else {
+				frappe.show_not_found(route);
+			}
+		}
+	},
+	make_page: function(double_column) {
+		var page_name = frappe.get_route_str(),
+			page = frappe.container.add_page(page_name);
+
+		frappe.ui.make_app_page({
+			parent: page,
+			single_column: !double_column
+		});
+		frappe.container.change_to(page_name);
+		return page;
+	}
+});