vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

test(postgres): enable test_unique_index_on_alter for postgres (#34719)

Browse source 
* test(postgres): enable test_unique_index_on_alter for postgres

* perf(postgres): Prevent redundant unique index creation on new columns
This commit is contained in:
Aarol D'Souza 2025-11-24 11:05:20 +05:30 • committed by GitHub
parent 73a1e89eca
commit 5fecde5a6a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
frappe/database/postgres/schema.py
View file

@ -76,6 +76,8 @@ class PostgresTable(DBTable):
query = [f"ADD COLUMN `{col.fieldname}` {col.get_definition()}" for col in self.add_column]
new_column_names = {col.fieldname for col in self.add_column}
for col in self.change_type:
using_clause = ""
if col.fieldtype in ("Datetime"):
@ -124,9 +126,10 @@ class PostgresTable(DBTable):
for col in self.add_unique:
# if index key not exists
create_contraint_query += 'CREATE UNIQUE INDEX IF NOT EXISTS "unique_{index_name}" ON `{table_name}`(`{field}`);'.format(
index_name=col.fieldname, table_name=self.table_name, field=col.fieldname
)
if col.fieldname not in new_column_names:
create_contraint_query += 'CREATE UNIQUE INDEX IF NOT EXISTS "unique_{index_name}" ON `{table_name}`(`{field}`);'.format(
index_name=col.fieldname, table_name=self.table_name, field=col.fieldname
)
drop_contraint_query = ""
for col in self.drop_index:

1
frappe/tests/test_db_update.py
View file

@ -139,7 +139,6 @@ class TestDBUpdate(IntegrationTestCase):
with self.subTest(f"Checking index {doctype.name} - {field.fieldname}"):
self.check_unique_indexes(doctype.name, field.fieldname)
@run_only_if(db_type_is.MARIADB)
def test_unique_index_on_alter(self):
"""Only one unique index should be added"""