From 60c1812cc248c126971a60fbd0b9e905f4860ac0 Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Fri, 2 Feb 2024 22:26:01 +0530 Subject: [PATCH] fix(run-tests): don't try to access `frappe.flags` before `frappe.init()` Broke in #24432 Signed-off-by: Akhil Narang --- frappe/commands/utils.py | 5 ++--- frappe/test_runner.py | 5 +++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/frappe/commands/utils.py b/frappe/commands/utils.py index a6eedf102a..333c37669f 100644 --- a/frappe/commands/utils.py +++ b/frappe/commands/utils.py @@ -772,9 +772,6 @@ def run_tests( click.secho(f"bench --site {site} set-config allow_tests true", fg="green") return - frappe.flags.skip_before_tests = skip_before_tests - frappe.flags.skip_test_records = skip_test_records - ret = frappe.test_runner.main( site, app, @@ -789,6 +786,8 @@ def run_tests( doctype_list_path=doctype_list_path, failfast=failfast, case=case, + skip_test_records=skip_test_records, + skip_before_tests=skip_before_tests, ) if len(ret.failures) == 0 and len(ret.errors) == 0: diff --git a/frappe/test_runner.py b/frappe/test_runner.py index 9c072ae8e4..62e5dd599a 100644 --- a/frappe/test_runner.py +++ b/frappe/test_runner.py @@ -51,6 +51,8 @@ def main( doctype_list_path=None, failfast=False, case=None, + skip_test_records=False, + skip_before_tests=False, ): global unittest_runner @@ -58,6 +60,9 @@ def main( if not frappe.db: frappe.connect() + frappe.flags.skip_before_tests = skip_before_tests + frappe.flags.skip_test_records = skip_test_records + if doctype_list_path: app, doctype_list_path = doctype_list_path.split(os.path.sep, 1) with open(frappe.get_app_path(app, doctype_list_path)) as f: