From cafa9fdcade68beae2b3235df1a7239406afd0c0 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Thu, 1 Aug 2024 17:01:40 +0530 Subject: [PATCH 1/2] fix: header block is not translatable --- frappe/public/js/frappe/views/workspace/blocks/header.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/views/workspace/blocks/header.js b/frappe/public/js/frappe/views/workspace/blocks/header.js index b5b42796d4..9da404c4c7 100644 --- a/frappe/public/js/frappe/views/workspace/blocks/header.js +++ b/frappe/public/js/frappe/views/workspace/blocks/header.js @@ -104,7 +104,7 @@ export default class Header extends Block { this._data = this.normalizeData(data); if (data.text !== undefined) { - let text = this._data.text || ""; + let text = __(this._data.text) || ""; const contains_html_tag = /<[a-z][\s\S]*>/i.test(text); this._element.innerHTML = contains_html_tag ? text From c308279158ecc4437bd613c8e43adf9d746cbadf Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Fri, 2 Aug 2024 12:05:07 +0530 Subject: [PATCH 2/2] fix: translate header inner text if it is a simple text --- frappe/public/js/frappe/views/workspace/blocks/header.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/frappe/public/js/frappe/views/workspace/blocks/header.js b/frappe/public/js/frappe/views/workspace/blocks/header.js index 9da404c4c7..072b054bad 100644 --- a/frappe/public/js/frappe/views/workspace/blocks/header.js +++ b/frappe/public/js/frappe/views/workspace/blocks/header.js @@ -106,6 +106,14 @@ export default class Header extends Block { if (data.text !== undefined) { let text = __(this._data.text) || ""; const contains_html_tag = /<[a-z][\s\S]*>/i.test(text); + + // apply translation to header text + let div = document.createElement("div"); + div.innerHTML = text; + let only_text = div.innerText; + only_text = frappe.utils.escape_html(only_text); + text = text.replace(only_text, __(only_text)); + this._element.innerHTML = contains_html_tag ? text : `${text}`;