diff --git a/frappe/printing/page/print_format_builder/print_format_builder.css b/frappe/printing/page/print_format_builder/print_format_builder.css index 1812721b3c..00ba537e55 100644 --- a/frappe/printing/page/print_format_builder/print_format_builder.css +++ b/frappe/printing/page/print_format_builder/print_format_builder.css @@ -67,19 +67,28 @@ margin-top: 5px; } +.field-label.data-pill { + border: 1px solid var(--dark-border-color); + padding: 4px 8px; + color: var(--text-light); +} + .print-format-builder-sidebar { - display: inline-block; - width: 160px; - vertical-align: top; - position: fixed; - top: 120px; - bottom: 0px; + padding: 5px; + top: var(--navbar-height); + height: 85vh; overflow-y: auto; + position: sticky; +} + +.filter-searchbox { + padding: 10px; + padding-left: 0; + margin-bottom: 10px; } .print-format-builder-main { display: inline-block; vertical-align: top; border-top: 0px; - margin-left: 160px; } diff --git a/frappe/printing/page/print_format_builder/print_format_builder.js b/frappe/printing/page/print_format_builder/print_format_builder.js index c889a423c9..ace09fab9b 100644 --- a/frappe/printing/page/print_format_builder/print_format_builder.js +++ b/frappe/printing/page/print_format_builder/print_format_builder.js @@ -42,14 +42,12 @@ frappe.PrintFormatBuilder = Class.extend({ this.page = frappe.ui.make_app_page({ parent: this.parent, title: __("Print Format Builder"), - single_column: true }); this.page.main.css({"border-color": "transparent"}); - this.page.sidebar = $('').appendTo(this.page.main); - this.page.main = $('').appendTo(this.page.main); + this.page.sidebar = $('').appendTo(this.page.sidebar); + this.page.main = $('').appendTo(this.page.main); // future-bindings for buttons on sections / fields // bind only once @@ -61,7 +59,6 @@ frappe.PrintFormatBuilder = Class.extend({ }, show_start: function() { this.page.main.html(frappe.render_template("print_format_builder_start", {})); - this.page.sidebar.html(""); this.page.clear_actions(); this.page.set_title(__("Print Format Builder")); this.start_edit_print_format(); @@ -168,16 +165,11 @@ frappe.PrintFormatBuilder = Class.extend({ }); }, setup_sidebar: function() { - var me = this; - this.page.sidebar.empty(); - // prepend custom HTML field var fields = [this.get_custom_html_field()].concat(this.meta.fields); - $(frappe.render_template("print_format_builder_sidebar", {fields: fields})) .appendTo(this.page.sidebar); - this.setup_field_filter(); }, get_custom_html_field: function() { diff --git a/frappe/printing/page/print_format_builder/print_format_builder_field.html b/frappe/printing/page/print_format_builder/print_format_builder_field.html index eb29092f28..772ffe426e 100644 --- a/frappe/printing/page/print_format_builder/print_format_builder_field.html +++ b/frappe/printing/page/print_format_builder/print_format_builder_field.html @@ -1,35 +1,35 @@ diff --git a/frappe/printing/page/print_format_builder/print_format_builder_sidebar.html b/frappe/printing/page/print_format_builder/print_format_builder_sidebar.html index 09777e4c43..bf6c12e49c 100644 --- a/frappe/printing/page/print_format_builder/print_format_builder_sidebar.html +++ b/frappe/printing/page/print_format_builder/print_format_builder_sidebar.html @@ -1,18 +1,18 @@ -
- + diff --git a/frappe/public/scss/variables.scss b/frappe/public/scss/variables.scss index 4c899bf0a9..acae66c24f 100644 --- a/frappe/public/scss/variables.scss +++ b/frappe/public/scss/variables.scss @@ -141,6 +141,8 @@ $card-box-shadow: 0px 0px 1px rgba(17, 43, 66, 0.16), 0px 1px 3px rgba(17, 43, 6 --text-xl: 18px; --text-2xl: 20px; + --navbar-height: 60px; + --text-bold: 500; --shadow-xs: 0px 0px 0.5px rgba(0,0,0,0.75), 0px 1px 2px rgba(0,0,0,0.13);