vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(notification): remove Custom type from send_alert_on as it's not getting used somewhere (#37256)

Browse source
This commit is contained in:
Sumit Jain 2026-02-20 19:57:21 +05:30 • committed by GitHub
parent cbe479412c
commit 617e4a8d8f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frappe/email/doctype/notification/notification.json
View file

@ -76,7 +76,7 @@
},
{
"depends_on": "eval:doc.channel=='Slack'",
"description": "To use Slack Channel, add a <a href=\"#List/Slack%20Webhook%20URL/List\">Slack Webhook URL</a>.",
"description": "To use Slack Channel, add a <a href=\"#List/Slack%20Webhook%20URL/List\" rel=\"noopener noreferrer\">Slack Webhook URL</a>.",
"fieldname": "slack_webhook_url",
"fieldtype": "Link",
"label": "Slack Channel",
@ -135,7 +135,7 @@
"fieldtype": "Select",
"in_list_view": 1,
"label": "Send Alert On",
"options": "\nNew\nSave\nSubmit\nCancel\nDays After\nDays Before\nMinutes After\nMinutes Before\nValue Change\nMethod\nCustom",
"options": "\nNew\nSave\nSubmit\nCancel\nDays After\nDays Before\nMinutes After\nMinutes Before\nValue Change\nMethod",
"reqd": 1,
"search_index": 1
},
@ -363,7 +363,7 @@
"icon": "fa fa-envelope",
"index_web_pages_for_search": 1,
"links": [],
"modified": "2025-10-21 23:14:52.345857",
"modified": "2026-02-19 18:07:15.888314",
"modified_by": "Administrator",
"module": "Email",
"name": "Notification",

1
frappe/email/doctype/notification/notification.py
View file

@ -57,7 +57,6 @@ class Notification(Document):
"Minutes Before",
"Value Change",
"Method",
"Custom",
]
filters: DF.Code | None
from_attach_field: DF.Literal[None]