vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor: update listview URL on all refresh

Browse source 
Previous changes only made it refresh on change of filters, this change
now updates URL ALWAYS.

Co-Auhtored-By: Suraj Shetty <surajshetty3416@gmail.com>
This commit is contained in:
Ankush Menat 2022-06-16 15:17:48 +05:30
parent 90bcbe46f1
commit 61c895c2fc
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
frappe/public/js/frappe/list/list_view.js
View file

@ -291,6 +291,7 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
super.refresh().then(() => {
this.render_header(refresh_header);
this.update_checkbox();
this.update_url_with_filters();
});
}
@ -1454,7 +1455,7 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
on_update() {}
on_filter_change() {
update_url_with_filters() {
window.history.replaceState(null, null, this.get_url_with_filters());
}

1
frappe/public/js/frappe/views/kanban/kanban_view.js
View file

@ -101,7 +101,6 @@ frappe.views.KanbanView = class KanbanView extends frappe.views.ListView {
} else {
this.page.clear_indicator();
}
super.on_filter_change();
}
save_kanban_board_filters() {

4
frappe/public/js/frappe/views/reports/query_report.js
View file

@ -57,7 +57,7 @@ frappe.views.QueryReport = class QueryReport extends frappe.views.BaseList {
this.menu_items = [];
}
on_filter_change() {
update_url_with_filters() {
window.history.replaceState(null, null, this.get_url_with_filters());
}
@ -506,7 +506,6 @@ frappe.views.QueryReport = class QueryReport extends frappe.views.BaseList {
if (df.on_change) f.on_change = df.on_change;
df.onchange = () => {
this.on_filter_change();
this.refresh_filters_dependency();
let current_filters = this.get_filter_values();
@ -681,6 +680,7 @@ frappe.views.QueryReport = class QueryReport extends frappe.views.BaseList {
frappe.hide_progress();
}).finally(() => {
this.hide_loading_screen();
this.update_url_with_filters();
});
}