From 6341ef3ac70e078ac3d2c6a65171abfcdc929d2a Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Fri, 2 Feb 2024 18:31:03 +0530 Subject: [PATCH] fix: kanban hide "add column" for std fields (#24707) * fix: build events * fix(kanban): Don't show custom column option on standard fields --- .../public/js/frappe/build_events/build_events.bundle.js | 2 +- .../public/js/frappe/views/kanban/kanban_board.bundle.js | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/build_events/build_events.bundle.js b/frappe/public/js/frappe/build_events/build_events.bundle.js index a191156bfa..5635502507 100644 --- a/frappe/public/js/frappe/build_events/build_events.bundle.js +++ b/frappe/public/js/frappe/build_events/build_events.bundle.js @@ -17,7 +17,7 @@ frappe.realtime.on("build_event", (data) => { if (parts.length === 2) { let filename = parts[0].split("/").slice(-1)[0]; - frappe.assets.executed_ = frappe.assets.executed_.filter( + frappe.assets._executed = frappe.assets._executed.filter( (asset) => !asset.includes(`${filename}.bundle`) ); } diff --git a/frappe/public/js/frappe/views/kanban/kanban_board.bundle.js b/frappe/public/js/frappe/views/kanban/kanban_board.bundle.js index d3690571dd..bca9889859 100644 --- a/frappe/public/js/frappe/views/kanban/kanban_board.bundle.js +++ b/frappe/public/js/frappe/views/kanban/kanban_board.bundle.js @@ -377,8 +377,13 @@ frappe.provide("frappe.views"); } function bind_add_column() { - if (!self.board_perms.write) { + let doctype = self.cur_list.doctype; + let fieldname = self.cur_list.board.field_name; + const is_custom_field = frappe.meta.get_docfield(doctype, fieldname)?.is_custom_field; + + if (!self.board_perms.write || !is_custom_field) { // If no write access to board, editing board (by adding column) should be blocked + // If standard field then users can't add options self.$kanban_board.find(".add-new-column").remove(); return; }