vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

perf: remove duplicate control assets (#17237)

Browse source 
* test: flaky tests due to uncleared filters

* perf: remove duplicate code in assets

Remove controls which are separately bundled too, saves ~1.1MB of
network transfer.

Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
This commit is contained in:
Ankush Menat 2022-06-20 14:28:38 +05:30 • committed by GitHub
parent b04bffe439
commit 6350406305
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
cypress/integration/awesome_bar.js
View file

@ -28,6 +28,7 @@ context('Awesome Bar', () => {
cy.findByPlaceholderText('ID')
.should('have.value', '%test%');
cy.clear_filters();
});
it('navigates to new form', () => {

4
cypress/integration/routing.js
View file

@ -16,6 +16,10 @@ describe("SPA Routing", { scrollBehavior: false }, () => {
cy.go_to_list("ToDo");
});
after(() => {
cy.clear_filters(); // avoid flake in future tests
});
it("should apply filter on list view from route", () => {
test_queries.forEach((query) => {
const full_url = `${list_view}${query}`;

1
frappe/public/js/form.bundle.js
View file

@ -10,7 +10,6 @@ import "./frappe/form/templates/set_sharing.html";
import "./frappe/form/templates/timeline_message_box.html";
import "./frappe/form/templates/users_in_sidebar.html";
import "./frappe/form/controls/control.js";
import "./frappe/views/formview.js";
import "./frappe/form/form.js";
import "./frappe/meta_tag.js";