From e580e8e5bb7bb2ab0b1e8e1bf3cd75a68374f063 Mon Sep 17 00:00:00 2001 From: barredterra <14891507+barredterra@users.noreply.github.com> Date: Mon, 9 Feb 2026 15:36:00 +0100 Subject: [PATCH] fix(Workspace): handle missing Workspace Sidebar on_trash --- frappe/desk/doctype/workspace/workspace.py | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/frappe/desk/doctype/workspace/workspace.py b/frappe/desk/doctype/workspace/workspace.py index 4ee11c1725..d051876ef2 100644 --- a/frappe/desk/doctype/workspace/workspace.py +++ b/frappe/desk/doctype/workspace/workspace.py @@ -130,11 +130,18 @@ class Workspace(Document): self.delete_from_my_workspaces() def delete_from_my_workspaces(self): - if not self.public: + if self.public: + return + + try: my_workspaces = frappe.get_doc("Workspace Sidebar", f"My Workspaces-{frappe.session.user}") - for w in my_workspaces.items: - if self.name == w.link_to: - frappe.delete_doc("Workspace Sidebar Item", w.name) + except frappe.DoesNotExistError: + frappe.clear_messages() + return + + for w in my_workspaces.items: + if self.name == w.link_to: + frappe.delete_doc("Workspace Sidebar Item", w.name) def after_delete(self): if disable_saving_as_public():