From 5e284db2060d93a3e3351207fa8cd91f0c51209d Mon Sep 17 00:00:00 2001
From: Saurabh <saurabh6790@gmail.com>
Date: Fri, 3 May 2019 18:17:04 +0530
Subject: [PATCH 1/2] fix: naming and provision to use same db credentails for
 secondary

---
 frappe/__init__.py | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/frappe/__init__.py b/frappe/__init__.py
index 75684d431e..1525c92cd5 100644
--- a/frappe/__init__.py
+++ b/frappe/__init__.py
@@ -187,14 +187,19 @@ def connect(site=None, db_name=None):
 	local.db = get_db(user=db_name or local.conf.db_name)
 	set_user("Administrator")
 
-def connect_read_only():
+def connect_secondary():
 	from frappe.database import get_db
+	user = local.conf.db_name
+	password = local.conf.db_password
 
-	local.read_only_db = get_db(host=local.conf.slave_host, user=local.conf.slave_db_name,
-		password=local.conf.slave_db_password)
+	if local.conf.different_credentials_for_secondary:
+		user = local.conf.secondary_db_name
+		password = local.conf.secondary_db_password
+
+	local.read_only_db = get_db(host=local.conf.secondary_host, user=user, password=password)
 
 	# swap db connections
-	local.master_db = local.db
+	local.primary_db = local.db
 	local.db = local.read_only_db
 
 def get_site_config(sites_path=None, site_path=None):
@@ -495,16 +500,17 @@ def whitelist(allow_guest=False, xss_safe=False):
 def read_only():
 	def innfn(fn):
 		def wrapper_fn(*args, **kwargs):
-			if conf.use_slave_for_read_only:
-				connect_read_only()
+			if conf.read_from_secondary:
+				connect_secondary()
+
 			try:
 				retval = fn(*args, **get_newargs(fn, kwargs))
 			except:
 				raise
 			finally:
-				if local and hasattr(local, 'master_db'):
+				if local and hasattr(local, 'primary_db'):
 					local.db.close()
-					local.db = local.master_db
+					local.db = local.primary_db
 
 			return retval
 		return wrapper_fn

From ca01c75ea410d2be2b1f85ed2cd6f689423b3250 Mon Sep 17 00:00:00 2001
From: Saurabh <saurabh6790@gmail.com>
Date: Fri, 10 May 2019 10:54:17 +0530
Subject: [PATCH 2/2] fix: naming

---
 frappe/__init__.py | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/frappe/__init__.py b/frappe/__init__.py
index 1525c92cd5..cd662cd6cb 100644
--- a/frappe/__init__.py
+++ b/frappe/__init__.py
@@ -187,20 +187,20 @@ def connect(site=None, db_name=None):
 	local.db = get_db(user=db_name or local.conf.db_name)
 	set_user("Administrator")
 
-def connect_secondary():
+def connect_replica():
 	from frappe.database import get_db
 	user = local.conf.db_name
 	password = local.conf.db_password
 
-	if local.conf.different_credentials_for_secondary:
-		user = local.conf.secondary_db_name
-		password = local.conf.secondary_db_password
+	if local.conf.different_credentials_for_replica:
+		user = local.conf.replica_db_name
+		password = local.conf.replica_db_password
 
-	local.read_only_db = get_db(host=local.conf.secondary_host, user=user, password=password)
+	local.replica_db = get_db(host=local.conf.replica_host, user=user, password=password)
 
 	# swap db connections
 	local.primary_db = local.db
-	local.db = local.read_only_db
+	local.db = local.replica_db
 
 def get_site_config(sites_path=None, site_path=None):
 	"""Returns `site_config.json` combined with `sites/common_site_config.json`.
@@ -500,8 +500,8 @@ def whitelist(allow_guest=False, xss_safe=False):
 def read_only():
 	def innfn(fn):
 		def wrapper_fn(*args, **kwargs):
-			if conf.read_from_secondary:
-				connect_secondary()
+			if conf.read_from_replica:
+				connect_replica()
 
 			try:
 				retval = fn(*args, **get_newargs(fn, kwargs))