From 641580a30003e1982bceca397b7c8de3acc70495 Mon Sep 17 00:00:00 2001 From: Suraj Shetty Date: Sat, 21 Mar 2020 18:11:42 +0530 Subject: [PATCH] test: Add a fallback default --- frappe/tests/test_db_update.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/frappe/tests/test_db_update.py b/frappe/tests/test_db_update.py index 1121366884..be3e102114 100644 --- a/frappe/tests/test_db_update.py +++ b/frappe/tests/test_db_update.py @@ -26,10 +26,11 @@ class TestDBUpdate(unittest.TestCase): fieldtype = get_fieldtype_from_def(field_def) - default = field_def.default if field_def.default is not None else 'NULL' + fallback_default = '0' if field_def.get('fieldtype') in frappe.model.numeric_fieldtypes else 'NULL' + default = field_def.default if field_def.default is not None else fallback_default self.assertEqual(fieldtype, table_column.type) - self.assertIn(table_column.default or 'NULL', [default, "'{}'".format(default), '0']) + self.assertIn(table_column.default or 'NULL', [default, "'{}'".format(default)]) def get_fieldtype_from_def(field_def): fieldtuple = frappe.db.type_map.get(field_def.fieldtype, ('', 0))