vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: restore missing helpful and not_helpful fields to help article doctype. (#19309)

Browse source 
* fix: restore fields 'helpful' and 'not_helpfull' when removed via 02ddaa5ee7\#diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46

* test: help article is helpful or not helpful

* chore: linter
This commit is contained in:
Devin Slauenwhite 2022-12-16 02:04:52 -05:00 • committed by GitHub
parent 6fe9f9b411
commit 64ec4276fc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 67 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
frappe/website/doctype/help_article/help_article.json
View file

@ -15,7 +15,11 @@
"section_break_7",
"content",
"likes",
"route"
"route",
"section_break_cww5",
"helpful",
"cb_00",
"not_helpful"
],
"fields": [
{
@ -78,6 +82,30 @@
"fieldtype": "Data",
"in_global_search": 1,
"label": "Route"
},
{
"default": "0",
"fieldname": "helpful",
"fieldtype": "Int",
"in_list_view": 1,
"label": "Helpful",
"read_only": 1
},
{
"fieldname": "cb_00",
"fieldtype": "Column Break"
},
{
"default": "0",
"fieldname": "not_helpful",
"fieldtype": "Int",
"in_list_view": 1,
"label": "Not Helpful",
"read_only": 1
},
{
"fieldname": "section_break_cww5",
"fieldtype": "Section Break"
}
],
"has_web_view": 1,
@ -85,7 +113,7 @@
"index_web_pages_for_search": 1,
"is_published_field": "published",
"links": [],
"modified": "2022-01-04 16:25:18.577325",
"modified": "2022-12-15 20:05:11.317400",
"modified_by": "Administrator",
"module": "Website",
"name": "Help Article",
@ -116,6 +144,7 @@
],
"sort_field": "modified",
"sort_order": "DESC",
"states": [],
"title_field": "title",
"track_changes": 1
}

37
frappe/website/doctype/help_article/test_help_article.py
View file

@ -7,4 +7,39 @@ from frappe.tests.utils import FrappeTestCase
class TestHelpArticle(FrappeTestCase):
pass
@classmethod
def setUpClass(cls) -> None:
cls.help_category = frappe.get_doc(
{
"doctype": "Help Category",
"category_name": "_Test Help Category",
}
).insert()
cls.help_article = frappe.get_doc(
{
"doctype": "Help Article",
"title": "_Test Article",
"category": cls.help_category.name,
"content": "_Test Article",
}
).insert()
def test_article_is_helpful(self):
from frappe.website.doctype.help_article.help_article import add_feedback
self.help_article.load_from_db()
self.assertEqual(self.help_article.helpful, 0)
self.assertEqual(self.help_article.not_helpful, 0)
add_feedback(self.help_article.name, "Yes")
add_feedback(self.help_article.name, "No")
self.help_article.load_from_db()
self.assertEqual(self.help_article.helpful, 1)
self.assertEqual(self.help_article.not_helpful, 1)
@classmethod
def tearDownClass(cls) -> None:
frappe.delete_doc(cls.help_article.doctype, cls.help_article.name)
frappe.delete_doc(cls.help_category.doctype, cls.help_category.name)