From 6502c4b340fb02e82c00a07a662d1ed9f55519a9 Mon Sep 17 00:00:00 2001 From: Gavin D'souza Date: Wed, 12 Jan 2022 14:50:27 +0530 Subject: [PATCH] fix: Don't add property value if NoneType or Falsy --- frappe/model/base_document.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/model/base_document.py b/frappe/model/base_document.py index 232f108615..a48a41c303 100644 --- a/frappe/model/base_document.py +++ b/frappe/model/base_document.py @@ -264,9 +264,9 @@ class BaseDocument(object): if isinstance(d[fieldname], list) and df.fieldtype not in table_fields: frappe.throw(_('Value for {0} cannot be a list').format(_(df.label))) - if d[fieldname] == None: + if d[fieldname] is None: _val = getattr(self, fieldname, None) - if not callable(_val): + if _val and not callable(_val): d[fieldname] = _val if convert_dates_to_str and isinstance(d[fieldname], (