vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor: extractor for custom fields

Browse source
This commit is contained in:
barredterra 2024-06-27 17:36:55 +02:00
parent 4c924a5a16
commit 65ab855571
2 changed files with 16 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
babel_extractors.csv
View file

@ -8,4 +8,4 @@ hooks.py,frappe.gettext.extractors.navbar.extract
**.js,frappe.gettext.extractors.javascript.extract
**.html,frappe.gettext.extractors.html_template.extract
**/custom/*.json,frappe.gettext.extractors.customizations.extract
**/fixtures/custom_field.json,frappe.gettext.extractors.custom_fields.extract
**/fixtures/custom_field.json,frappe.gettext.extractors.custom_field.extract
1 hooks.py frappe.gettext.extractors.navbar.extract
8 **.js frappe.gettext.extractors.javascript.extract
9 **.html frappe.gettext.extractors.html_template.extract
10 **/custom/*.json frappe.gettext.extractors.customizations.extract
11 **/fixtures/custom_field.json frappe.gettext.extractors.custom_fields.extract frappe.gettext.extractors.custom_field.extract

31
frappe/gettext/extractors/custom_fields.py → frappe/gettext/extractors/custom_field.py
View file

@ -11,7 +11,8 @@ EXCLUDE_SELECT_OPTIONS = [
def extract(fileobj, *args, **kwargs):
"""
Extract messages from DocType JSON files. To be used to babel extractor
Extract messages from Custom Field fixtures. To be used by babel extractor.
:param fileobj: the file-like object the messages should be extracted from
:rtype: `iterator`
"""
@ -21,30 +22,29 @@ def extract(fileobj, *args, **kwargs):
return
messages = []
fields = data
for field in fields:
print(field)
fieldtype = field.get("fieldtype")
fieldname = field.get("fieldname")
label = field.get("label")
doctype = field.get("dt")
for custom_field in data:
print(custom_field)
fieldtype = custom_field.get("fieldtype")
fieldname = custom_field.get("fieldname")
label = custom_field.get("label")
doctype = custom_field.get("dt")
if label:
messages.append((label, f"Label of a {fieldtype} Custom Field in DocType '{doctype}'"))
messages.append((label, f"Label of the '{fieldname}' ({fieldtype}) field in DocType '{doctype}'"))
_label = label
else:
_label = fieldname
if description := field.get("description"):
if description := custom_field.get("description"):
messages.append(
(
description,
f"Description of the '{_label}' ({fieldtype}) Custom Field in DocType '{doctype}'",
f"Description of the '{_label}' ({fieldtype}) field in DocType '{doctype}'",
)
)
if message := field.get("options"):
if message := custom_field.get("options"):
if fieldtype == "Select":
if fieldname in EXCLUDE_SELECT_OPTIONS:
continue
@ -57,14 +57,13 @@ def extract(fileobj, *args, **kwargs):
messages.extend(
(
option,
f"Option for the '{_label}' ({fieldtype}) Custom Field in DocType '{doctype}'",
f"Option for the '{_label}' ({fieldtype}) field in DocType '{doctype}'",
)
for option in select_options
)
elif fieldtype == "HTML":
messages.append(
(message, f"Content of the '{_label}' ({fieldtype}) Custom Field in DocType '{doctype}'")
(message, f"Content of the '{_label}' ({fieldtype}) field in DocType '{doctype}'")
)
# By using "pgettext" as the function name we can supply the doctype as context
yield from ((None, "pgettext", (doctype, message), [comment]) for message, comment in messages)
yield from ((None, "_", message, [comment]) for message, comment in messages)