From 66eb3774920ac5c8107354c25db0a2a8fd98514f Mon Sep 17 00:00:00 2001 From: Corentin Flr <10946971+cogk@users.noreply.github.com> Date: Tue, 30 May 2023 07:07:26 +0200 Subject: [PATCH] fix(role): Set desk properties (e.g. search_bar) to 1 for roles with desk access (#21162) Replace get_doc with new_doc, because default values are not retrieved when using get_doc. Some roles with desk_access had no access to most features of the desk, such as the search bar or the form's sidebar. --- frappe/core/doctype/doctype/doctype.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/frappe/core/doctype/doctype/doctype.py b/frappe/core/doctype/doctype/doctype.py index 9a0613e6ca..91a317dbff 100644 --- a/frappe/core/doctype/doctype/doctype.py +++ b/frappe/core/doctype/doctype/doctype.py @@ -1679,7 +1679,9 @@ def make_module_and_roles(doc, perm_fieldname="permissions"): for role in list(set(roles)): if frappe.db.table_exists("Role", cached=False) and not frappe.db.exists("Role", role): - r = frappe.get_doc(dict(doctype="Role", role_name=role, desk_access=1)) + r = frappe.new_doc("Role") + r.role_name = role + r.desk_access = 1 r.flags.ignore_mandatory = r.flags.ignore_permissions = True r.insert() except frappe.DoesNotExistError as e: