From 67671c98bbee1e2ecec7fa317ecd50ce26368143 Mon Sep 17 00:00:00 2001 From: shariquerik Date: Thu, 29 Apr 2021 14:10:33 +0530 Subject: [PATCH] fix: Grid row color picker field not working --- .../public/js/frappe/form/controls/color.js | 28 ++++++++++++------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/frappe/public/js/frappe/form/controls/color.js b/frappe/public/js/frappe/form/controls/color.js index bf04581abd..814a716d2b 100644 --- a/frappe/public/js/frappe/form/controls/color.js +++ b/frappe/public/js/frappe/form/controls/color.js @@ -48,7 +48,24 @@ frappe.ui.form.ControlColor = frappe.ui.form.ControlData.extend({ $(window).off('hashchange.color-popover'); }); - this.$wrapper.find('.control-input').on('click', (e) => { + this.picker.on_change = (color) => { + this.set_value(color); + }; + + if (!this.selected_color) { + this.selected_color = $(`
`); + this.selected_color.insertAfter(this.$input); + } + + if (!this.$wrapper.find('.control-input').get(0)) { + this.$wrapper.find('.selected-color') + .css({ + "top": "calc(23% + 1px)", + "z-index": "2" + }); + } + + this.$wrapper.find('.selected-color').parent().on('click', (e) => { this.$wrapper.popover('toggle'); if (!this.get_color()) { this.$input.val(''); @@ -63,15 +80,6 @@ frappe.ui.form.ControlColor = frappe.ui.form.ControlData.extend({ this.$wrapper.popover('hide'); }); }); - - this.picker.on_change = (color) => { - this.set_value(color); - }; - - if (!this.selected_color) { - this.selected_color = $(`
`); - this.selected_color.insertAfter(this.$input); - } }, refresh() { this._super();