vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

test: Add test case to check get_common_transition_actions

Browse source
This commit is contained in:
Suraj Shetty 2019-06-02 10:56:20 +05:30
parent 8528298b55
commit 67b41deb44
2 changed files with 25 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
frappe/model/workflow.py
View file

@ -5,6 +5,7 @@ from __future__ import unicode_literals
import frappe
from frappe.utils import cint
from frappe import _
from six import string_types
import json
class WorkflowStateError(frappe.ValidationError): pass
@ -180,10 +181,12 @@ def bulk_workflow_approval(docnames, doctype, action):
@frappe.whitelist()
def get_common_transition_actions(docs, doctype):
common_actions = []
docs = json.loads(docs)
if isinstance(docs, string_types):
docs = json.loads(docs)
try:
for (i, doc) in enumerate(docs, 1):
doc['doctype'] = doctype
if not doc.get('doctype'):
doc['doctype'] = doctype
actions = [t.get('action') for t in get_transitions(doc, raise_exception=True) \
if has_approval_access(frappe.session.user, doc, t)]
if not actions: return []
@ -192,7 +195,7 @@ def get_common_transition_actions(docs, doctype):
except WorkflowStateError:
pass
return common_actions
return list(common_actions)
def show_progress(docnames, message, i, description):
n = len(docnames)

22
frappe/workflow/doctype/workflow/test_workflow.py
View file

@ -9,6 +9,7 @@ from frappe.model.workflow import apply_workflow, WorkflowTransitionError, Workf
class TestWorkflow(unittest.TestCase):
def setUp(self):
frappe.db.sql('DELETE FROM `tabToDo`')
if not getattr(self, 'workflow', None):
self.workflow = create_todo_workflow()
frappe.set_user('Administrator')
@ -50,9 +51,24 @@ class TestWorkflow(unittest.TestCase):
self.workflow.transitions[0].condition = ''
self.workflow.save()
def test_get_common_transition_actions(self):
todo1 = frappe.get_doc(dict(doctype='ToDo', description='workflow ' + random_string(10))).insert()
todo2 = frappe.get_doc(dict(doctype='ToDo', description='workflow ' + random_string(10))).insert()
todo3 = frappe.get_doc(dict(doctype='ToDo', description='workflow ' + random_string(10))).insert()
todo4 = frappe.get_doc(dict(doctype='ToDo', description='workflow ' + random_string(10))).insert()
def test_get_common_transition_actions():
actions = get_common_transition_actions(['asdf', 'asdf', 'asf'], 'ToDo')
actions = get_common_transition_actions([todo1, todo2, todo3, todo4], 'ToDo')
self.assertSetEqual(set(actions), set(['Approve', 'Reject']))
apply_workflow(todo1, 'Reject')
apply_workflow(todo2, 'Reject')
apply_workflow(todo3, 'Approve')
actions = get_common_transition_actions([todo1, todo2, todo3], 'ToDo')
self.assertListEqual(actions, [])
actions = get_common_transition_actions([todo1, todo2], 'ToDo')
self.assertListEqual(actions, ['Review'])
def test_if_workflow_actions_were_processed(self):
frappe.db.sql('delete from `tabWorkflow Action`')
@ -74,7 +90,7 @@ class TestWorkflow(unittest.TestCase):
def create_todo_workflow():
if frappe.db.exists('Workflow', 'Test ToDo'):
return frappe.get_doc('Workflow', 'Test ToDo')
return frappe.get_doc('Workflow', 'Test ToDo').save(ignore_permissions=True)
else:
frappe.get_doc(dict(doctype='Role',
role_name='Test Approver')).insert(ignore_if_duplicate=True)