vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

feat: show doctype description on workspace link hover (#24598)

Browse source
This commit is contained in:
Rucha Mahabal 2024-02-06 15:38:59 +05:30 • committed by GitHub
parent 33d0db364b
commit 68003a23d5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 37 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
frappe/desk/desktop.py
View file

@ -193,6 +193,9 @@ class Workspace:
item["count"] = count
if item.get("link_type") == "DocType":
item["description"] = frappe.get_meta(item.link_to).description
# Translate label
item["label"] = _(item.label) if item.label else _(item.name)

50
frappe/public/js/frappe/widgets/links_widget.js
View file

@ -60,9 +60,7 @@ export default class LinksWidget extends Widget {
const get_link_for_item = (item) => {
if (is_link_disabled(item)) {
return `<span class="link-content ellipsis disabled-link">${
item.label ? item.label : item.name
}</span>
return `<span class="link-content ellipsis disabled-link">${item.link_title}</span>
<div class="module-link-popover popover fade top in" role="tooltip" style="display: none;">
<div class="arrow"></div>
<h3 class="popover-title" style="display: none;"></h3>
@ -74,14 +72,18 @@ export default class LinksWidget extends Widget {
}
if (item.youtube_id)
return `<span class="link-content help-video-link ellipsis" data-youtubeid="${
item.youtube_id
}">
${item.label ? item.label : item.name}</span>`;
return `
<span class="link-content help-video-link ellipsis" data-youtubeid="${item.youtube_id}">
${item.link_title}
</span>
`;
return `<span class="link-content ellipsis">${
item.label ? item.label : item.name
} ${frappe.utils.icon("es-line-arrow-up-right", "xs", "", "", "ml-2")} </span>`;
return `
<span class="link-content ellipsis">
<span class="link-text">${item.link_title}</span>
${frappe.utils.icon("es-line-arrow-up-right", "xs", "", "", "ml-2")}
</span>
`;
};
this.link_list = this.links.map((item) => {
@ -97,14 +99,30 @@ export default class LinksWidget extends Widget {
}
const route = frappe.utils.generate_route(opts);
item.link_title = item.label ? item.label : item.name;
return $(`<a href="${route}" class="link-item ellipsis ${
item.onboard ? "onboard-spotlight" : ""
} ${disabled_dependent(item)}" type="${item.type}" title="${
item.label ? item.label : item.name
}">
const $link = $(`
<a href="${route}" class="link-item ellipsis
${item.onboard ? "onboard-spotlight" : ""} ${disabled_dependent(item)}"
type="${item.type}" title="${item.link_title}"
>
${get_link_for_item(item)}
</a>`);
</a>
`);
if (item.description) {
$link.find(".link-text").popover({
trigger: "hover",
placement: "top",
title: item.link_title,
content: () =>
`<div class="link-description small">${__(item.description)}</div>`,
html: true,
delay: { show: 600, hide: 100 },
});
}
return $link;
});
if (this.in_customize_mode) {
this.body.empty();