From 68a5ac2b34782f3f9bdca898c7428ea2e2e7d05d Mon Sep 17 00:00:00 2001 From: Jon Lockwood Date: Tue, 20 Jul 2021 14:09:55 +0930 Subject: [PATCH] fix: username required as part of the search the login/user name is required to find the user issue #13738 --- frappe/integrations/doctype/ldap_settings/ldap_settings.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/frappe/integrations/doctype/ldap_settings/ldap_settings.py b/frappe/integrations/doctype/ldap_settings/ldap_settings.py index cf926dcbc1..376db1b039 100644 --- a/frappe/integrations/doctype/ldap_settings/ldap_settings.py +++ b/frappe/integrations/doctype/ldap_settings/ldap_settings.py @@ -177,14 +177,12 @@ class LDAPSettings(Document): fetch_ldap_groups = getattr(user, self.ldap_group_field).values - if ldap_object_class is not None: conn.search( search_base=self.organizational_unit_for_groups, - search_filter="(&(objectClass={0})({1}={2}))".format(ldap_object_class,ldap_group_members_attribute, user), + search_filter="(&(objectClass={0})({1}={2}))".format(ldap_object_class,ldap_group_members_attribute, frappe.as_unicode(frappe.form_dict.usr)), attributes=ldap_attributes) # Build search query - if len(conn.entries) >= 1: fetch_ldap_groups = []