From 68d4a5ad82a28bcfcd20ca7545e5d1cb6d8bc469 Mon Sep 17 00:00:00 2001 From: Xiaoguang Sun Date: Tue, 26 Dec 2023 14:42:19 +0800 Subject: [PATCH] Do not call begin in updatedb after syncing (#23934) Do not call begin in updatedb after syncing as commit does it already. Signed-off-by: Xiaoguang Sun --- frappe/database/mariadb/database.py | 2 +- frappe/database/postgres/database.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/database/mariadb/database.py b/frappe/database/mariadb/database.py index 1096821e66..00cbd1c332 100644 --- a/frappe/database/mariadb/database.py +++ b/frappe/database/mariadb/database.py @@ -440,7 +440,7 @@ class MariaDBDatabase(MariaDBConnectionUtil, MariaDBExceptionUtil, Database): self.commit() db_table.sync() - self.begin() + self.commit() def get_database_list(self): return self.sql("SHOW DATABASES", pluck=True) diff --git a/frappe/database/postgres/database.py b/frappe/database/postgres/database.py index 617350cca5..48dd55381a 100644 --- a/frappe/database/postgres/database.py +++ b/frappe/database/postgres/database.py @@ -329,7 +329,7 @@ class PostgresDatabase(PostgresExceptionUtil, Database): self.commit() db_table.sync() - self.begin() + self.commit() @staticmethod def get_on_duplicate_update(key="name"):