vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #37591 from GursheenK/web-link-encoding-for-file-attachments

Browse source 
fix: attachment links with web URL fragments
This commit is contained in:
Gursheen Kaur Anand 2026-02-26 17:13:30 +05:30 • committed by GitHub
commit 6a1c17ca79
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
frappe/public/js/frappe/form/sidebar/attachments.js
View file

@ -180,8 +180,18 @@ frappe.ui.form.Attachments = class Attachments {
file_url = "/files/" + attachment.file_name;
}
}
const is_web_url = /^(https?:)?\/\//i.test(file_url);
file_url = encodeURI(file_url);
// hash is not escaped, https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURI
return encodeURI(file_url).replace(/#/g, "%23");
// only encode hash if it's a local file path, not a web URL
if (!is_web_url) {
file_url = file_url.replace(/#/g, "%23");
}
return file_url;
}
get_file_id_from_file_url(file_url) {
var fid;