vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: delete as much indexes from each table (#9684)

Browse source 
in cases of customization, errors such as pymysql.err.InternalError: (1091, "Can't DROP 'unique_item'; check that column/key exists") may rise up
This commit is contained in:
gavin 2020-03-13 15:02:47 +05:30 • committed by GitHub
parent fcdb923d2e
commit 6a25a33d49
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
frappe/patches/v12_0/delete_duplicate_indexes.py
View file

@ -1,12 +1,14 @@
import frappe
from pymysql import InternalError
# This patch deletes all the duplicate indexes created for same column
# The patch only checks for indexes with UNIQUE constraints
def execute():
if frappe.db.db_type != 'mariadb': return
all_tables = frappe.db.get_tables()
if frappe.db.db_type != 'mariadb':
return
all_tables = frappe.db.get_tables()
final_deletion_map = frappe._dict()
for table in all_tables:
@ -34,11 +36,14 @@ def execute():
# build drop index query
for (table_name, index_list) in final_deletion_map.items():
query = "ALTER TABLE `{}` ".format(table_name)
query_parts = []
query_list = []
alter_query = "ALTER TABLE `{}`".format(table_name)
for index in index_list:
query_parts.append("DROP INDEX `{}`".format(index))
query_list.append("{} DROP INDEX `{}`".format(alter_query, index))
query = query + ', '.join(query_parts)
frappe.db.sql(query)
for query in query_list:
try:
frappe.db.sql(query)
except InternalError:
pass